Skip to content

Conversation

@Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Apr 7, 2025

Following a successful import or reimport, a JSON blob for statistics is generated to provide the differential of finding activity. There was a section in the delta JSON blob that referred to a key labeled left untouched. This value does not comply with REST norms, and has been renamed to left_untouched.

[sc-6122]

@Maffooch Maffooch requested a review from mtesauro as a code owner April 7, 2025 21:55
@github-actions github-actions bot added New Migration Adding a new migration file. Take care when merging. docs unittests ui labels Apr 7, 2025
@dryrunsecurity
Copy link

dryrunsecurity bot commented Apr 7, 2025

DryRun Security Summary

DefectDojo Version 2.46.x documentation and code updates involve renaming the 'left untouched' key to 'left_untouched' and identifying a potential input validation vulnerability in the display_tags.py template tag function.

Expand for full summary

Summary: DefectDojo Version 2.46.x documentation and code updates focus on renaming the "left untouched" key to "left_untouched" across multiple files, improving naming consistency.

Security Findings:

  1. Potential Input Validation Vulnerability in display_tags.py
    • Location: dojo/templatetags/display_tags.py
    • Risk: Lack of input validation in replace_underscore_with_space function
    • Explanation: Function does not check input type, which could potentially cause TypeError if non-string input is provided

No other direct security vulnerabilities were identified in the provided summaries.

View PR in the DryRun Dashboard.

@Maffooch Maffooch added this to the 2.46.0 milestone Apr 7, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten
Copy link
Member

valentijnscholten commented Apr 9, 2025

I'm late to the party @Maffooch, but I think we should go with just "untouched" to avoid dealing with spaces/underscores etc.

@Maffooch
Copy link
Contributor Author

Maffooch commented Apr 9, 2025

@mtesauro what are your thoughts on Val's comment? I am not opposed to going with just untouched - it would actually simplify this PR a bit to do so

@mtesauro
Copy link
Contributor

I am good with just "untouched"

@Maffooch
Copy link
Contributor Author

@valentijnscholten thanks for raising that! We will go with untouched

@github-actions github-actions bot removed the ui label Apr 11, 2025
@dryrunsecurity
Copy link

DryRun Security

This pull request contains a documentation and code patch for DefectDojo version 2.46.x with terminology updates and no identified security vulnerabilities.

All finding details can be found in the DryRun Security Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit f751349 into DefectDojo:dev Apr 11, 2025
78 checks passed
@Maffooch Maffooch deleted the import-payload branch April 11, 2025 16:08
Maffooch added a commit that referenced this pull request Apr 21, 2025
* Import/Reimport Stats: Change name of left untouched

* Update migrations

* Failed spell check

* Update migration again

* Migrate from `left_untouched` to `untouched`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs New Migration Adding a new migration file. Take care when merging. unittests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants