Skip to content

Conversation

@valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Apr 28, 2025

Adds the author and date to the most recent note display in lists of findings.

The js/css lib used doesn't support styling the content, this is what it looks like:

image

The unrelated commit is a Ruff fix that was automatically applied. When I remove it, it complains that it is a Ruff violation :-) So I left it.

@dryrunsecurity
Copy link

dryrunsecurity bot commented Apr 28, 2025

DryRun Security

This pull request introduces potential information exposure risks through enhanced metadata display in a template and may reveal undefined name warnings in a test file due to linter suppression removal.

💭 Unconfirmed Findings (2)
Vulnerability Potential Sensitive Information Exposure
Description In the file 'dojo/templates/dojo/findings_list_snippet.html', the note display now explicitly shows author and timestamp metadata in a client-side tooltip, potentially revealing more detailed information about findings and their documentation.
Vulnerability Potential Exposure of Undefined Name Warnings
Description In the file 'tests/import_scanner_test.py', the removal of a linter suppression directive may now expose code quality warnings related to undefined names or potential import issues.

All finding details can be found in the DryRun Security Dashboard.

@Maffooch Maffooch added this to the 2.46.0 milestone Apr 28, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 3c9e7ff into DefectDojo:bugfix Apr 29, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants