Skip to content

False Positive Status: Update docs #12332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Maffooch merged 1 commit into from
Apr 30, 2025
Merged

False Positive Status: Update docs #12332

Maffooch merged 1 commit into from
Apr 30, 2025

Conversation

@Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Apr 28, 2025

No description provided.

@Maffooch Maffooch requested a review from mtesauro as a code owner April 28, 2025 22:26
@github-actions github-actions bot added the docs label Apr 28, 2025
@dryrunsecurity
Copy link

dryrunsecurity bot commented Apr 28, 2025

DryRun Security

No security concerns detected in this pull request.

All finding details can be found in the DryRun Security Dashboard.

mtesauro
mtesauro approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten
Copy link
Member

valentijnscholten commented Apr 29, 2025

Is the False Positive History feature (that also works with import) still a thing? I think that's why the original text was there.

@paulOsinski
Copy link
Contributor

paulOsinski commented Apr 29, 2025

Looks good!

@Maffooch
Copy link
Contributor Author

Maffooch commented Apr 29, 2025

Is the False Positive History feature (that also works with import) still a thing? I think that's why the original text was there.

Yes, False Positive History is still a thing, but it was not actually mentioned in the original text. It may be worth making a separate write up for false positive history. Is that something you would be willing to take on?

@Maffooch Maffooch added this to the 2.46.0 milestone Apr 29, 2025
@valentijnscholten
Copy link
Member

valentijnscholten commented Apr 29, 2025

Is the False Positive History feature (that also works with import) still a thing? I think that's why the original text was there.

Yes, False Positive History is still a thing, but it was not actually mentioned in the original text. It may be worth making a separate write up for false positive history. Is that something you would be willing to take on?

I have never used it and I am not sure I am aware of the original use case / goal it is trying to achieve. Happy to leave it for now.

@Maffooch
Copy link
Contributor Author

Maffooch commented Apr 29, 2025

Let's leave it for now and revisit in the future

@Maffooch Maffooch merged commit 09acb3a into bugfix Apr 30, 2025
79 checks passed
@Maffooch Maffooch deleted the Maffooch-patch-1 branch April 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtesauro mtesauro mtesauro approved these changes

@valentijnscholten valentijnscholten valentijnscholten approved these changes

@dogboat dogboat dogboat approved these changes

+1 more reviewer

@hblankenship hblankenship hblankenship approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

2.46.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Maffooch @valentijnscholten @paulOsinski @mtesauro @dogboat @hblankenship