Reduce subscription api calls #2305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrtnd
reviewed
Nov 19, 2025
| } | ||
|
|
||
| if (apiSubscription?.subscription?.status !== 'active') { | ||
| if (subscriptionType !== 'api' && subscription?.status !== 'active') { |
Member
There was a problem hiding this comment.
will return false for llamafeed && active
Member
Author
There was a problem hiding this comment.
as it should have? 🤔 overage shouldn't be available to llamafeed subs
Member
There was a problem hiding this comment.
if subscription IS llamapay and is active this will return false and we'll proceed to enableOverageMutation.mutateAsync()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already updated auth backend to allow sending subscription status requests without the subscription type, it'll reduce number of calls we make to check if user has an active sub 3->1. Also refactored the subscription hook a bit