Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solidlyv3 pool tvl, add more chains #1782

Merged
merged 6 commits into from
Mar 27, 2025
Merged

Conversation

abanchev
Copy link
Contributor

No description provided.

@abanchev abanchev marked this pull request as draft March 21, 2025 15:22
@abanchev abanchev marked this pull request as ready for review March 21, 2025 16:31
@abanchev
Copy link
Contributor Author

We have pools that share the same address, while being on different chains, i will append chain name to the pool property, but i am not sure if this is okay with your api

@abanchev
Copy link
Contributor Author

abanchev commented Mar 21, 2025

CI error likely caused by missing ALCHEMY_CONNECTION_ETHEREUM env variable

@slasher125
Copy link
Collaborator

i've tried locally, but its breaking. can you confirm that the tests run fine on your end?

@abanchev
Copy link
Contributor Author

@slasher125 All is working here
image
in my env i have only GRAPH_API_KEY and ALCHEMY_CONNECTION_ETHEREUM

@slasher125
Copy link
Collaborator

ah, its breaking here cause of the graph api key...cause alchemy one is set. anyways,
can u confirm that the pool values are the exact same addresses but just with the chain as prefix?

@abanchev
Copy link
Contributor Author

abanchev commented Mar 26, 2025 via email

@slasher125 slasher125 merged commit 32bf548 into DefiLlama:master Mar 27, 2025
1 check failed
@slasher125
Copy link
Collaborator

@abanchev
sry had to revert this, its still breaking for me testing locally, even with keys set.
generally, would be better if we don't rely on alchemy altogether and just use our sdk instead

@abanchev
Copy link
Contributor Author

@slasher125 i was just refactoring existing code that was already using alchemy
anyway i will rewrite it to use the sdk instead, it should not take long, and i will open another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants