Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean Translation #272

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Add Korean Translation #272

merged 2 commits into from
Jul 6, 2022

Conversation

evan-hwang
Copy link
Contributor

Description

I'm adding a translation for a Korean developer.
I am also a Korean developer.
I translated it because Korean developers love the project so much. Thank you. 🙏

I interpreted the word "Streak" as "work that I've been doing."
So I translated 'Current Streak' into 'Current Continuous Commit Count' and 'Longest Streak' into 'Maximum Continuous Commit Count'.

Fixes #236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

스크린샷 2022-07-05 오후 10 57 42

I'm adding a translation for a Korean developer.

I interpreted the word "Streak" as "work that I've been doing." 
So I translated 'Current Streak' into 'Current Continuous Commit Count' and 'Longest Streak' into 'Maximum Continuous Commit Count'.
@DenverCoder1
Copy link
Owner

Looks great, thanks for he contribution!

I interpreted the word "Streak" as "work that I've been doing."
So I translated 'Current Streak' into 'Current Continuous Commit Count' and 'Longest Streak' into 'Maximum Continuous Commit Count'.

Contributions include commits, pull requests, and issues that you create in standalone repositories (See docs).

Is there possibly a way to translate that does not reference specifically commits, but includes any of the above? Would that make sense?

Thanks

@evan-hwang
Copy link
Contributor Author

@DenverCoder1

Thank you for the feedback. 🙏

I corrected the translation according to the feedback, so please check it.
(I also referred to the translation of other languages.)

the basis for translation

  1. Winning Streak means winning consecutive games in baseball. So I translated "streak" to mean continuous.
  2. 'contribution' does not mean 'commit'. I revised it to a translation that works for Korean developers.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again 🎉

@DenverCoder1 DenverCoder1 merged commit 35dd11b into DenverCoder1:main Jul 6, 2022
@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗪 Add Translations to Streak Stats
2 participants