Skip to content

Support ingressClassName, ingress tls, and extraObjects#23

Merged
nscuro merged 2 commits intoDependencyTrack:mainfrom
nissessenap:ingress_improvment
Apr 20, 2024
Merged

Support ingressClassName, ingress tls, and extraObjects#23
nscuro merged 2 commits intoDependencyTrack:mainfrom
nissessenap:ingress_improvment

Conversation

@nissessenap
Copy link
Contributor

@nissessenap nissessenap commented Apr 19, 2024

Solves #20

@nissessenap nissessenap mentioned this pull request Apr 19, 2024
Open
@nissessenap
Copy link
Contributor Author

nissessenap commented Apr 19, 2024

FYI @nscuro , this is a simplification of #17.
It solves the same issue and I think it will be easier for the community to maintain in the long run, and I still think it's easy enough to use. Especially since it follows how other helm charts normally look.

@nscuro nscuro added the enhancement New feature or request label Apr 19, 2024
@nscuro
Copy link
Member

nscuro commented Apr 19, 2024

Thanks @nissessenap, really like the simplicity!

Even if we end up adding more options in the future (not sold on that), I think it's great to start with the minimum viable version proposed here.

Do you mind bumping the chart version to 0.2.0?

@nissessenap
ingress improvment and extraObjectst
c193764 
Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
@nissessenap
bump chart 0.2.0
6d79172 
Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
@nissessenap
Copy link
Contributor Author

nissessenap commented Apr 20, 2024

Ahh, missed that one. Done
Do you want me to squash the commits as well @nscuro ?

nscuro
nscuro approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

No need to squash yourself, the repo has been set up to only allow squash merges.

@nscuro nscuro changed the title ingress improvment & extraObjects Support ingressClassName, ingress tls, and extraObjects Apr 20, 2024
@nscuro nscuro merged commit cec9a54 into DependencyTrack:main Apr 20, 2024
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@nissessenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades
6cad4c1 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro mentioned this pull request Jun 12, 2024
Merged
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@nissessenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades
81e3fc5 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@nissessenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades
29d3478 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit that referenced this pull request Jun 12, 2024
@nscuro @pawelmrowka
@nissessenap @jazark @Wihrt @stexandev @tvannahl @SergK
Port enhancement from dependency-track chart to hyades (#91)
f9336b6 
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Signed-off-by: nscuro <nscuro@protonmail.com>
Co-authored-by: Pawel Mrowka <pawel.mrowka@shoper.pl>
Co-authored-by: Edvin Norling <edvin.norling@kognic.com>
Co-authored-by: Jaz Ark <jaz@edgeimpulse.com>
Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>
Co-authored-by: Stefan Hynek <stefan.hynek@uni-goettingen.de>
Co-authored-by: Theodor van Nahl <theodor.vannahl@docmorris.de>
Co-authored-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nscuro nscuro nscuro approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nissessenap @nscuro