Skip to content

fix: podSecurityContext for frontend #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

fernandezcuesta
Copy link
Contributor

@fernandezcuesta fernandezcuesta commented Jul 1, 2025

Add the ability to customize the podSecurityContext for the frontend pod.
Also, add the missing API and Kind for the PVC, which triggers diffs on ArgoCD.

image

@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 06:39
@fernandezcuesta fernandezcuesta requested a review from a team as a code owner July 1, 2025 06:39
@fernandezcuesta fernandezcuesta changed the title fix: podSecurityContext for frontend, add missing api and kind for pv… fix: podSecurityContext for frontend Jul 1, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the missing pod security context for the frontend pod and updates the PVC configuration in the API server StatefulSet to include the required apiVersion and kind fields.

  • Enable customization of the pod security context for the frontend pod
  • Update the values schema and deployment template with podSecurityContext settings
  • Add missing apiVersion and kind fields to the PVC volumeClaimTemplates for the API server to resolve ArgoCD diffs

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
charts/dependency-track/values.yaml Added podSecurityContext settings for the frontend pod
charts/dependency-track/values.schema.json Included podSecurityContext property in the schema
charts/dependency-track/templates/frontend/deployment.yaml Updated deployment to conditionally add the pod security context
charts/dependency-track/templates/api-server/statefulset.yaml Added missing apiVersion and kind fields for the PVC volumeClaimTemplates
Comments suppressed due to low confidence (2)

charts/dependency-track/templates/frontend/deployment.yaml:31

  • Consider aligning the key name in the rendered output with the values file (i.e., using 'podSecurityContext') for clarity, as 'securityContext' may be confused with container-level security settings.
      {{- with .Values.frontend.podSecurityContext }}

charts/dependency-track/templates/api-server/statefulset.yaml:133

  • Ensure the new 'apiVersion' and 'kind' fields in the volumeClaimTemplates adhere to the expected schema and consider adding documentation if this change impacts downstream processes like ArgoCD integrations.
    kind: PersistentVolumeClaim

@nscuro nscuro added the enhancement New feature or request label Jul 8, 2025
@nscuro nscuro merged commit 449b04c into DependencyTrack:main Jul 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants