Skip to content

ETCCDI indices #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

ETCCDI indices #1392

wants to merge 18 commits into from

Conversation

mnurisso
Copy link
Collaborator

PR description:

Implementation of CLI scripts to evaluate ETCCDI indices as described here.
Only a preliminar list of indices is available.

They work at the moment with native healpix data and no regrid, but this can be easily extended.

A more rigorous structure as a class, with definition yaml files and only a final cli to run as a proper diagnostic would be beneficial.


Please leave the checkboxes that apply to this pull request.
If you find a missing checkbox, please add it to the list.
Make sure to complete the checkboxes before applying the "ready to merge" label.
Please apply the "run tests" label if you want to trigger CI tests.

  • Tests are included if a new feature is included.
  • Documentation is included if a new feature is included.
  • Docstrings are updated if needed.
  • Changelog is updated.
  • Notebooks which requires changes are updated.
  • environment.yml and pyproject.toml are updated if needed, together with the lumi installation tool.
  • Diagnostic config files path are updated in the console if needed

@mnurisso mnurisso added diagnostic improvement Improvement to existing functionality labels Oct 16, 2024
@mnurisso mnurisso added this to the nextGEMS Hackathon milestone Oct 16, 2024
@jhardenberg
Copy link
Collaborator

@mnurisso sorry if I see and comment on this one only now. The all seem very simple but computing these indices can be very tricky .... there is actually a nice library which does this and which we could simply call: https://xclim.readthedocs.io/en/stable/

@jhardenberg
Copy link
Collaborator

Also the old ETCCDI set of definitions was later superseded by ET-SCI indices (a superset actually).

@jhardenberg
Copy link
Collaborator

The main problem in computing them is those which depend on percentiles and fine details on how percentile boundaries are computed.

@oloapinivad oloapinivad added the on-hold Tasks that are on-hold at the moment label Nov 8, 2024
@mnurisso mnurisso marked this pull request as draft February 13, 2025 15:55
@mnurisso mnurisso added do not merge! and removed on-hold Tasks that are on-hold at the moment labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic do not merge! improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants