New seaice diagnostic implementation #1684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oloapinivad
reviewed
Feb 21, 2025
…oth methods. Use deepcopy to avoid overwriting of the data before calculation of std if it is requested. Raise: errors if time coord is missing.
Refactor: split seaice plotting function in two. In this way regions_type_plotter can call both timeseries and seasonalcycle. Also adapt fig_height to plot_type Patch: check class att exist in description generation Docstring: added to some functions Add: some logging
Add: initial function name in description based on plot_type.
FIx: restore call of class attr with 'self' for labels
Add config file path in diagnostic_config list
Fix: remove duplicate line in timeseries
Remove: titles for plotting Add: checking function and improve logging Enhance: get correct area and coord depending if a regrid is done or not, following changes in #1768
duplicated code for extent and volume methods. Cleaning and linting code. Adding: annual and monthlty options and std dates
…s and minor changes
…tic class. Same for load_regions. Add: longname metadata. Remove: show_regions as not useful method. Harmonise spaces in code
…l structure, and use the longname from the definitions file. Improve: _update_description for model date string
…ls). Add: function for description
…nal reading Add: merge_attrs make read_regions_file private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Issues closed by this pull request:
Close #1683
Please leave the checkboxes that apply to this pull request.
If you find a missing checkbox, please add it to the list.
Make sure to complete the checkboxes before applying the "ready to merge" label.
Please apply the "run tests" label if you want to trigger CI tests.