lat & lon profiles plot as Diagnostic tool #1934

mcadau · 2025-05-15T10:42:12Z

PR description:

The aim of this PR is to make the zonal and longitudinal profiles plot from the Tropical Rainfall diagnostic part of the AQUA diagnostic tools.

Tests are included if a new feature is included.
Documentation is included if a new feature is included.
Docstrings are updated if needed.
Changelog is updated.
Notebooks which requires changes are updated.

Issues closed by this pull request:

Close #1923

src/aqua/graphics/lat_lon_profiles.py

jhardenberg · 2025-05-16T17:49:17Z

src/aqua/graphics/lat_lon_profiles.py

+    logger = log_configure(loglevel, 'plot_lat_lon_profiles')
+    ConfigStyle(style=style, loglevel=loglevel)
+
+    def data_coordinate_means(data, mean_type : str):


Defining this function inside the other is not really the style which we used in AQUA. If this functuon is used only by plot_lat_lon_profiles() the start its name with "_" (ie def _data_coordinate_means(...) )

Yes my plan was to move it in one of the util folders, so that other functions might be able to use it, also because is not a super specific computation. You think it would be better to keep it here and private?

src/aqua/graphics/multiple_lines.py

src/aqua/graphics/lat_lon_profiles.py

jhardenberg · 2025-05-16T17:53:21Z

src/aqua/graphics/lat_lon_profiles.py

+            raise ValueError("mean_type must be 'zonal' or 'meridional'")
+
+
+    if data_list is not None:


If data_list is not none what is plotted monthly data or annual_data? I would pass only one "data" object. Then you can test if it a slist (and iterate over it) or do only one plot

jhardenberg · 2025-05-16T17:55:18Z

src/aqua/graphics/lat_lon_profiles.py

+        if mean_type == 'zonal':
+            return data.mean(dim='lon')
+        elif mean_type == 'meridional':
+            return data.mean(dim='lat')


I am pretty sure that this is wrong ... the mean should be a weighted mean (weighting by cell areas)!

Yep I agree with you. I was trying to display the plots on the notebook first, and now I'll compute the weighted-area mean

mcadau · 2025-05-16T19:08:34Z

@jhardenberg thanks for your review. Yes you may have noticed that this PR is still quite draft, and it still needs some work. Thanks for your suggestions!

… and annual data methods

…tLonProfiles

mnurisso · 2025-05-16T10:58:59Z

src/aqua/graphics/lat_lon_profiles.py

+    logger = log_configure(loglevel, 'plot_lat_lon_profiles')
+    ConfigStyle(style=style, loglevel=loglevel)
+
+    def data_coordinate_means(data, mean_type : str):


Idk if this is worth an entire function. Btw, is this defined inside the other function? If yes I'd avoid this

src/aqua/graphics/lat_lon_profiles.py

mnurisso · 2025-07-02T10:42:34Z

src/aqua/graphics/lat_lon_profiles.py

+from .styles import ConfigStyle
+
+def plot_lat_lon_profiles(monthly_data: xr.DataArray = None,
+                          annual_data: xr.DataArray = None,


use only data argument instead of monthly and annual

mnurisso · 2025-07-02T10:44:49Z

src/aqua/graphics/lat_lon_profiles.py

+
+def plot_lat_lon_profiles(monthly_data: xr.DataArray = None,
+                          annual_data: xr.DataArray = None,
+                          data_labels: list = None,


missing reference arguments

also missing the std argument for the reference

mnurisso · 2025-07-02T10:48:07Z

src/aqua/graphics/multiple_lines.py

+from .styles import ConfigStyle
+from .lat_lon_profiles import plot_lat_lon_profiles
+
+def plot_multi_lines(data_arrays_list,


check if this can be totally removed

mnurisso · 2025-07-02T10:55:41Z

src/aqua_diagnostics/lat_lon_profiles/lat_lon_profiles.py

+                                                                                 lat_limits=lat_limits)
+
+                # Initialize the possible results
+                self.hourly = None


only self. annual and self.seasonal

mnurisso · 2025-07-02T10:56:26Z

src/aqua_diagnostics/lat_lon_profiles/lat_lon_profiles.py

+                else:
+                        self.data.attrs['standard_name'] = var
+
+        def compute_std(self, freq: str, exclude_incomplete: bool = True, center_time: bool = True,


keep it commented for now

mnurisso · 2025-07-02T10:56:52Z

src/aqua_diagnostics/lat_lon_profiles/lat_lon_profiles.py

+                elif str_freq == 'annual':
+                        self.std_annual = data
+
+        def save_netcdf(self, diagnostic: str, freq: str,


to correct according to your new results

mnurisso · 2025-07-02T10:58:08Z

src/aqua_diagnostics/lat_lon_profiles/plot_base.py

+    with various data arrays for different frequencies (hourly, daily,
+    monthly, annual, seasonal annual) and their standard deviations.
+    """
+    def __init__(self, hourly_data=None, daily_data=None,


change input args

mnurisso · 2025-07-02T11:00:15Z

src/aqua_diagnostics/lat_lon_profiles/plot_lat_lon_profiles.py

+from aqua.logger import log_configure
+from .plot_base import PlotBaseMixin
+
+class PlotLatLonProfiles(PlotBaseMixin):


Remove mixin, take the individual class taking care of annual plot and seasonal plot with two methods

…ultiple_lines because redundant

…nput in PlotLatLonProfiles

…at_lon_profiles

First definition of plot_lat_lon_profiles

29e4ece

mcadau self-assigned this May 15, 2025

mcadau added 5 commits May 15, 2025 20:13

lat_lon_profiles improvement

00f1904

lat_lon_profiles notebook start

8447ba1

adjustments on plot_lat_lon_profiles

3be4a73

plot multiple lines function

c7162bd

lat-lon profiles notebook update

9763d3a

jhardenberg reviewed May 16, 2025

View reviewed changes

mcadau added 2 commits June 4, 2025 19:31

legend and multiple lines profiles update

7cd0304

Notebook partial updates

5dd1a66

mnurisso added diagnostic improvement Improvement to existing functionality labels Jun 5, 2025

mnurisso added this to the AQUA Diagnostic refactoring milestone Jun 5, 2025

mcadau and others added 16 commits June 5, 2025 15:39

Merge remote-tracking branch 'origin/main' into plot_lat_lon_profiles

e84f554

minor multiple lines adjustments

709511e

implementation of lon/lat mean on fldstat

ab4d1bf

profiles notebook completion

41aede9

temporary lat_lon_profiles adjustments

fa2f135

new lat_lon_profiles diagnostic start

e3a360a

new lat_lon_profiles diagnostic notebook start

32e6048

fldstat logger adjustments

e22d056

LatLonProfiles logger on mean type adjustments

e977439

start of the plotting of the notebook and on the class

df5cb45

fldstat logger adjustments

111a7a5

removal of the mean inside the latlonprofiles graphic function

0fe6e0d

PlotLatLonTimeseries draft update

1dcd085

LatLonProfiles diagnostic notebook update

3a632ff

PlotLatLonProfiles notebook further adjustments

9991c6d

latest LatLonProfiles notebook update

d48c23c

mcadau and others added 13 commits June 27, 2025 10:55

seasonal and annual means refactoring

2cde958

worflow update

f9ac6b1

seasonal means months fix

2bad7be

minor reader fix

91a80f4

more robust data info implementation on PlotLatLonProfiles

9665c80

seasonal means notebook implementation

28cc824

Mutiple lines plot update in diagnostic notebook

26d87cf

multi line plotting implementation in PlotLatLonProfiles

821aaf9

Refactoring in two different files of the multiple lines and seasonal…

fc16574

… and annual data methods

Modularization of diagnostic plotting classes in BaseMixin and PlotLa…

021c8d5

…tLonProfiles

further plot classes synchronisation

eabc975

notebook comments implementation

6884bd2

minor notebook metadata fixes + docstrings

70cacc0

mnurisso requested changes Jul 2, 2025

View reviewed changes

mcadau added 14 commits July 2, 2025 16:33

single data input parameter to plot_lat_lon_profiles and removal of m…

d2cb461

…ultiple_lines because redundant

reference data integration for single profiles

bce722f

seasonal and annual plot on single line ref data fix

ef72e4f

final plot ref data update in the notebook

2abb0bf

reference data line in notebook plots adjustments

71847f7

further ref data plot line adjustments

a15a30a

Removal of the PlotBaseMixin class for PlotLatLonProfiles

c082615

Splitting of the annual means plot and the seasonal means plots

b0a9874

delete dixtincion between different frequencies keeping only "data" i…

d88b5bd

…nput in PlotLatLonProfiles

notebook fixes and captions adjustments

fba7d0c

creation of regions data for LatLonProfiles

9d37441

LatLonProfiles refactoring

0ea2c5b

LatLonProfiles notebook restyling

cb5fa72

Merge branch 'main' of github.com:DestinE-Climate-DT/AQUA into plot_l…

3f09c14

…at_lon_profiles

		raise ValueError("mean_type must be 'zonal' or 'meridional'")


		if data_list is not None:

lat & lon profiles plot as Diagnostic tool #1934

Are you sure you want to change the base?

lat & lon profiles plot as Diagnostic tool #1934

Conversation

mcadau commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

Issues closed by this pull request:

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcadau commented May 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcadau commented May 15, 2025 •

edited

Loading