-
Notifications
You must be signed in to change notification settings - Fork 2
Update push analysis for ensembles #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
"include realization in the generated experiment.yaml" is not needed since realization can be derived from the directory. |
I still have to test comprehensively the whole machinery but the main infrastructure is in place. I tried to maintain it still compatible with the old structure (if nothing else is specified the tools keep working exactly as before). The new options are:
Due to compatibility there is some extra code to accomodate both old and new cases. When in the next months all our experiment output will be stored with the new structure we can make a PR to simplify |
I did an integrated test, I guess it is time that somebody gives a look |
I will merge the main to implement #2074 and test again |
ok, I'm going to merge ecmean and then I'll check this PR for merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
+ Coverage 77.41% 77.43% +0.02%
==========================================
Files 77 77
Lines 7761 7774 +13
Branches 1467 1467
==========================================
+ Hits 6008 6020 +12
- Misses 1175 1176 +1
Partials 578 578 |
PR description:
Extends push_analysis and related tools to deal with ensembles.
For compatibility for now the functionality is implemented through a
-e
flag which will be removed some day when not necessary any more.Tasks
make-content.py
to support the new folder layoutpush_analysis.py
to account for realization in folder structure and configIssues closed by this pull request:
Close #2048