Skip to content

Node 24 #11107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Node 24 #11107

wants to merge 1 commit into from

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Jun 27, 2025

For some reason there were more changes than usual required to use DIM under Node 24.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to run under Node 24 and adjusts related configurations. Key changes include upgrading Node images and version references, updating import syntax for ESM compatibility, and minor dependency updates.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Added/chalk dependency version update.
docker-compose.yml Updated the Docker node image from 18 to 24.
config/webpack.ts Adjusted import paths/extensions for ESM compatibility; added __dirname workaround and updated stats configuration.
config/notify-webpack-plugin.ts Converted imports to use type-only annotations for clarity.
config/content-security-policy.ts Updated type import syntax for FeatureFlags.
.nvmrc Updated Node version from 22 to 24.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (4)

config/webpack.ts:569

  • [nitpick] Consider adding a brief comment or documentation note to clarify the purpose of the 'deep' option in the stats configuration for future maintainers.
        deep: true,

package.json:122

  • [nitpick] Ensure that updating the chalk dependency is intentional and that its version is compatible with all usages across the project.
    "chalk": "^5.4.1",

docker-compose.yml:6

  • Confirm that switching to Node 24 does not introduce compatibility issues with existing components or dependencies in the application.
    image: node:24

config/webpack.ts:528

  • [nitpick] Using __dirname in an ESM context is a common workaround; ensure that this definition remains clear and does not conflict with any future Node updates or module handling.
      const __dirname = path.dirname(fileURLToPath(import.meta.url));

@bhollis
Copy link
Contributor Author

bhollis commented Jun 27, 2025

OK, Node 24 introduces the ability to require esm, which should be good but breaks some assumptions in the webpack CLI that worked around the old node not supporting that. Good times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant