Skip to content

i18next parser #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

i18next parser #11240

wants to merge 6 commits into from

Conversation

delphiactual
Copy link
Contributor

@delphiactual delphiactual commented Jul 23, 2025

switch from i18next-scanner as it is no longer being maintained and has been silently failing in workflows.

while most of our functionality is retained, some caveats:

i18n.json is technically no longer used... not sure how i feel about that
dynamicKeys are populated via regex in the config file, I am sure someone here can make something much more graceful than my hamfisted attempt, but all our keys came thru.

EDIT: we can still use i18n.json by having pnpm i18n copy i18n.json over en.json before running i18next-parser

@delphiactual delphiactual changed the title I18next parser i18next parser Jul 23, 2025
@bhollis
Copy link
Contributor

bhollis commented Jul 23, 2025

Yeah I'd looked into this, but at least as of pretty recently I was seeing the pnpm i18n task working: I could add or remove keys from i18n.json and they'd get reflected in en.json. I'll have to test when I'm around my personal computer but I am not sure exactly what isn't working now.

I had my own i18next-parser branch but never got it working to my liking.

copy i18n.json over en.json on run
remove obsolete keys from en.json
@bhollis
Copy link
Contributor

bhollis commented Jul 24, 2025

BTW just confirmed that the existing i18n-scanner appears to work locally. Not saying we shouldn't switch but it's not broken afaik

@delphiactual
Copy link
Contributor Author

it is silently failing in workflows...

https://github.com/DestinyItemManager/DIM/actions/runs/16492679800/job/46630963716

@delphiactual
Copy link
Contributor Author

@bhollis what version of node are you running locally?

@bhollis
Copy link
Contributor

bhollis commented Jul 25, 2025

I'm using the version specified in our .nvmrc

@delphiactual
Copy link
Contributor Author

The nvmrc only specifies 22, the latest 22 from node.js is 22.17.1, which is what is being downloaded by the github workflow, it was also only released last week.

@bhollis
Copy link
Contributor

bhollis commented Jul 26, 2025

Yeah I'm on v22.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants