Skip to content

found 'Vexcalibur Catalyst' in defs ands SourceInfo #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2025
Merged

found 'Vexcalibur Catalyst' in defs ands SourceInfo #11254

merged 3 commits into from
Jul 26, 2025
+33 −10

Conversation

delphiactual
Copy link
Contributor

@delphiactual delphiactual commented Jul 24, 2025 •
edited
Loading

image 
PS C:\GitHub\DIM> pnpm i18n

> [email protected] i18n C:\GitHub\DIM
> i18next-scanner --config ./i18next-scanner.config.cjs

(node:4772) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

PS C:\GitHub\DIM> node -v
v22.17.1

@delphiactual delphiactual requested a review from bhollis July 24, 2025 19:42
@delphiactual
Copy link
Contributor Author

I also noticed that catalyst source information is available in the defs
https://data.destinysets.com/i/Record:3787307395
image

@delphiactual delphiactual changed the title found 'Vexcalibur Catalyst' in defs found 'Vexcalibur Catalyst' in defs ands SourceInfo Jul 25, 2025
bhollis
bhollis reviewed Jul 25, 2025
View reviewed changes
src/app/records/presentation-nodes.ts Outdated
});
}

if (recordDef.recordTypeName === 'Exotic Catalysts' && recordDef.stateInfo.obscuredDescription) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a translated value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow I can't believe I missed that.

@delphiactual delphiactual merged commit 1a8a49c into master Jul 26, 2025
6 checks passed
@delphiactual delphiactual deleted the vexcalibur-data-in-def branch July 26, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhollis bhollis bhollis approved these changes

@FlaminSarge FlaminSarge Awaiting requested review from FlaminSarge

@chainrez chainrez Awaiting requested review from chainrez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delphiactual @bhollis