Include item name in warning about bad wishlist hashes#11715
Open
rootvector2 wants to merge 1 commit intoDestinyItemManager:masterfrom
Open
Include item name in warning about bad wishlist hashes#11715rootvector2 wants to merge 1 commit intoDestinyItemManager:masterfrom
rootvector2 wants to merge 1 commit intoDestinyItemManager:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11691
In the Armory view, when a wishlist perk hash doesn't match a weapon's rollable perks, the warning tooltip now includes the perk's name in parentheses for easier identification.
Before: "The perk hash 2541826827 does not appear on this item..."
After: "The perk hash 2541826827 (Repulsor Brace) does not appear on this item..."
If the hash doesn't resolve to a known item in the manifest, it falls back to "Unknown Item".
Changes
src/app/armory/AllWishlistRolls.tsx— Look up perk name viadefs.InventoryItem.get(hash)in theInvalidPlugcomponentconfig/i18n.json— Add{{perkName}}interpolation to theUnknownPerkHashstringsrc/locale/en.json— Updated viapnpm i18n