-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add new loadout parameters and settings #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bhollis
commented
Jun 29, 2025
- Add minStat/maxStat to stat constraints, replacing minTier/maxTier.
- Add a list of perk constraints for armor to LoadoutParameters.
- Add vaultArmorGroupingStyle to Settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new loadout parameters and settings while updating dependency versions and tooling commands. Key changes include:
- Replacing minTier/maxTier with minStat/maxStat and adding a new perks field in loadouts.
- Adding a new vaultArmorGroupingStyle field to settings with corresponding migration logic.
- Bumping dependency versions and updating commands in package.json and related files.
Reviewed Changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
package.json | Updated generation scripts with prettier and bumped dependency versions |
dim-api-types/package.json | Bumped version from 1.35.0 to 1.36.0 |
api/stately/schema/types.ts | Updated usage of protobuf scalar types |
api/stately/schema/settings.ts | Added vaultArmorGroupingStyle and migration block |
api/stately/schema/search.ts | Adjusted uint32 import for consistency |
api/stately/schema/loadouts.ts | Added perks and minStat/maxStat fields with migration logic |
api/stately/schema/loadout-share.ts | Removed redundant uint32 import |
api/stately/schema/README.md | Updated API key paths for new wishlist endpoints |
api/shapes/settings.ts | Added vaultArmorGroupingStyle in the Settings interface/default settings |
api/shapes/loadouts.ts | Updated LoadoutParameters interface with perks and stat constraint deprecations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
api/stately/schema/loadouts.ts:273
- The new minStat and maxStat fields do not include validation constraints like the previous minTier and maxTier fields. Consider applying similar validation rules if applicable for consistency.
minStat: { type: uint32, required: false },
api/stately/schema/README.md:19
- There appears to be ambiguity in the wishlist endpoint naming. Please confirm that the intended endpoints and their URL patterns are consistent and well-documented.
- `/wl-:wishlistId`: `WishListInfo` (uuid? rand?)