Conversation
Contributor
bhollis
commented
Jun 29, 2025
- Add minStat/maxStat to stat constraints, replacing minTier/maxTier.
- Add a list of perk constraints for armor to LoadoutParameters.
- Add vaultArmorGroupingStyle to Settings.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new loadout parameters and settings while updating dependency versions and tooling commands. Key changes include:
- Replacing minTier/maxTier with minStat/maxStat and adding a new perks field in loadouts.
- Adding a new vaultArmorGroupingStyle field to settings with corresponding migration logic.
- Bumping dependency versions and updating commands in package.json and related files.
Reviewed Changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated generation scripts with prettier and bumped dependency versions |
| dim-api-types/package.json | Bumped version from 1.35.0 to 1.36.0 |
| api/stately/schema/types.ts | Updated usage of protobuf scalar types |
| api/stately/schema/settings.ts | Added vaultArmorGroupingStyle and migration block |
| api/stately/schema/search.ts | Adjusted uint32 import for consistency |
| api/stately/schema/loadouts.ts | Added perks and minStat/maxStat fields with migration logic |
| api/stately/schema/loadout-share.ts | Removed redundant uint32 import |
| api/stately/schema/README.md | Updated API key paths for new wishlist endpoints |
| api/shapes/settings.ts | Added vaultArmorGroupingStyle in the Settings interface/default settings |
| api/shapes/loadouts.ts | Updated LoadoutParameters interface with perks and stat constraint deprecations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
api/stately/schema/loadouts.ts:273
- The new minStat and maxStat fields do not include validation constraints like the previous minTier and maxTier fields. Consider applying similar validation rules if applicable for consistency.
minStat: { type: uint32, required: false },
api/stately/schema/README.md:19
- There appears to be ambiguity in the wishlist endpoint naming. Please confirm that the intended endpoints and their URL patterns are consistent and well-documented.
- `/wl-:wishlistId`: `WishListInfo` (uuid? rand?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.