Fix eval caching for path flakes #131
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is somewhat hacky since the accessor/input fingerprint situation is a bit of a mess.
cole-h
reviewed
Jun 27, 2025
| @@ -354,6 +354,8 @@ std::pair<ref<SourceAccessor>, Input> Input::getAccessorUnchecked(ref<Store> sto | |||
|
|
|||
| if (!accessor->fingerprint) | |||
| accessor->fingerprint = result.getFingerprint(store); | |||
| else | |||
There was a problem hiding this comment.
Since you note "this is kinda hacky" in the PR body, should we add a FIXME here with some context on why that is and how it could be fixed at some point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A user reported that eval caching doesn't work in DetSys Nix for path flakes.
This fix is somewhat hacky since the accessor/input fingerprint situation is a bit of a mess.
Context