Rename nix profile install to nix profile add
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
force-pushed
the
rename-nix-profile-install-to-add
branch
from
9ecb8ff to
0e8a13a
Compare
grahamc
force-pushed
the
rename-nix-profile-install-to-add
branch
from
0e8a13a to
7b0d72e
Compare
edolstra
reviewed
Apr 7, 2025
|
This PR is hard to review with the formatting changes. |
grahamc
force-pushed
the
rename-nix-profile-install-to-add
branch
from
7b0d72e to
b454ae9
Compare
|
@edolstra fixed! |
grahamc
commented
Apr 7, 2025
grahamc
force-pushed
the
rename-nix-profile-install-to-add
branch
from
b454ae9 to
8443f01
Compare
edolstra
reviewed
Apr 7, 2025
src/nix/profile.cc
Outdated
| {"remove", []() { return make_ref<CmdProfileRemove>(); }}, | ||
| {"upgrade", []() { return make_ref<CmdProfileUpgrade>(); }}, | ||
| {"list", []() { return make_ref<CmdProfileList>(); }}, | ||
| {"diff-closures", []() { return make_ref<CmdProfileDiffClosures>(); }}, | ||
| {"history", []() { return make_ref<CmdProfileHistory>(); }}, | ||
| {"rollback", []() { return make_ref<CmdProfileRollback>(); }}, | ||
| {"wipe-history", []() { return make_ref<CmdProfileWipeHistory>(); }}, | ||
| // 2025-04-05 Deprecated in favor of "add" | ||
| {"install", []() { return make_ref<CmdProfileAdd>(); }}, |
There was a problem hiding this comment.
It's better to do this as a proper alias (see aliases in main.cc), otherwise nix profile install shows up as its own manual page which is probably not what we want. However aliases currently only handles top-level commands I think.
There was a problem hiding this comment.
Yeah, it does only handle top-level commands at the moment. That'd be a great thing to fix.
There was a problem hiding this comment.
@grahamc Okay, I've made it a proper alias.
edolstra
changed the title
nix profile install to nix profile add.nix profile install to nix profile add
edolstra
approved these changes
Apr 10, 2025
This allows subcommands to declare aliases, e.g. `nix store ping` is now a proper alias of `nix store info`.
edolstra
force-pushed
the
rename-nix-profile-install-to-add
branch
from
1fa9b5a to
497fe6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The verb
addis a better antonym for the verbremove. Nix also does not have install hooks or general behavior often associated with "installing".Context
I've had (and heard) concerns before about add/remove vs. install/remove confusion. Sharing the video about the
git addvideo fix had Carl Hedgren suggesting it on Twitter.