Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some class components have unmount method that matches ctor, not mount #3669

Merged

Conversation

VasilyStrelyaev
Copy link
Contributor

No description provided.

@VasilyStrelyaev VasilyStrelyaev self-assigned this Jan 31, 2024
@VasilyStrelyaev VasilyStrelyaev changed the title fix class components where unmount is matched with ctor, not mount fix: some class components have unmount method that match ctor, not mount Jan 31, 2024
@VasilyStrelyaev VasilyStrelyaev changed the title fix: some class components have unmount method that match ctor, not mount fix: some class components have unmount method that matches ctor, not mount Jan 31, 2024
Copy link
Contributor

@dxvladislavvolkov dxvladislavvolkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VasilyStrelyaev VasilyStrelyaev merged commit 4d74165 into DevExpress:master Feb 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants