ci: aggregate success results into a single job #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This greatly simplifies the terraform configuration, because we only have to require the "Success" status check. It’s simpler than listing all the checks in terraform which can be sometimes problematic: - We need to list all the job names generated using `matrix` - We need to open a PR in infrastructure-as-code AND to deploy the change when we change / add / remove a job Here, we just list the required jobs directly as dependencies of the `success` job, without having to modify multiple repositories. Job dependencies also does not use the job names, but the job "key", so there is much less things to enumerate. Less error prone overall.
thenextman
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the terraform configuration, because we only have to require the "Success" status check. It’s simpler than listing all the checks in terraform which can be sometimes problematic:
matrixHere, we just list the required jobs directly as dependencies of the
successjob, without having to modify multiple repositories. Job dependencies also does not use the job names, but the job "key", so there is much less things to enumerate. Less error prone overall.