Improve smart card credentials handling #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awakecoding
approved these changes
May 16, 2024
CBenoit
reviewed
May 17, 2024
Comment on lines
+361
to
+365
| use winscard::SmartCardInfo; | ||
|
|
||
| use crate::sspi::utils::raw_wide_str_trim_nulls; | ||
| use crate::utils::str_encode_utf16; | ||
| use crate::winscard::scard_context::{DEFAULT_CARD_NAME, MICROSOFT_DEFAULT_CSP}; |
There was a problem hiding this comment.
style: move at the beginning of the function
rationale: it's useful to have imports local to the function, but for readability they should be at the top (not mixed with logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this pull request I improved the smart card credentials handling.
cc @awakecoding