Skip to content

CredSSP: fix SNI in TLS client hello packet #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2024
Merged

CredSSP: fix SNI in TLS client hello packet #244

merged 3 commits into from
May 27, 2024

Conversation

TheBestTvarynka
Copy link
Collaborator

@TheBestTvarynka TheBestTvarynka commented May 27, 2024 •
edited
Loading

Hi,
In this PR, I've fixed the SNI in the first TLS packet. Previously, we just set stub_string.
image
Now the server name is correct!

cc @awakecoding

@TheBestTvarynka TheBestTvarynka requested a review from CBenoit May 27, 2024 15:57
@TheBestTvarynka TheBestTvarynka self-assigned this May 27, 2024
@pacmancoder pacmancoder self-requested a review May 27, 2024 16:06
pacmancoder
pacmancoder approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@pacmancoder pacmancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-quality code as always, looks good to me! 👍

@pacmancoder pacmancoder merged commit 74ca5f0 into master May 27, 2024
40 checks passed
@pacmancoder pacmancoder deleted the fix/sni-sspicredssp branch May 27, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacmancoder pacmancoder pacmancoder approved these changes

@CBenoit CBenoit Awaiting requested review from CBenoit

Assignees

@TheBestTvarynka TheBestTvarynka

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBestTvarynka @pacmancoder