Fix null check in save_out_buf and save_out_buf_wide functions
#251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these function always check that the data pointer is not `null`. But actually we need to check it only in the `OutBuffer::Allocated` case. Move this check into the corresponding `match` branch and updated the safety comment.
…and `WinScardHandle`;
TheBestTvarynka
added a commit
that referenced
this pull request
Jun 10, 2024
) * fix(ffi): winscard: `save_out_buf_wide` and `save_out_buf` functions. Previously, these function always check that the data pointer is not `null`. But actually we need to check it only in the `OutBuffer::Allocated` case. Move this check into the corresponding `match` branch and updated the safety comment. * feat(ffi): winscard: improve logging for the `WinScardContextHandle` and `WinScardHandle`;
TheBestTvarynka
added a commit
that referenced
this pull request
Jun 10, 2024
…f_wide` functions (#251) Previously, these function always check that the data pointer is not `null`. But actually we need to check it only in the `OutBuffer::Allocated` case. Move this check into the corresponding `match` branch and updated the safety comment. Improve logging for the `WinScardContextHandle` and `WinScardHandle`.
CBenoit
pushed a commit
that referenced
this pull request
Jun 11, 2024
…f_wide` functions (#251) Previously, these function always check that the data pointer is not `null`. But actually we need to check it only in the `OutBuffer::Allocated` case. Move this check into the corresponding `match` branch and updated the safety comment. Improve logging for the `WinScardContextHandle` and `WinScardHandle`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After the last intermediate PR I did some dev testing to check if everything is sill working. I found a small mistake and fixed it in this PR.
Also, I've improved the logging a little bit.