ci: fix success job #270
Merged
ci: fix success job #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
force-pushed
the
ci-fix-success-job
branch
from
e9ed2a1 to
043d592
Compare
awakecoding
approved these changes
Jul 15, 2024
It seems that GitHub considers skipped job as green when it comes to merging pull requests. We need to make the success job fails for real if any previous job is failed.
CBenoit
force-pushed
the
ci-fix-success-job
branch
from
4d2b96f to
932bac3
Compare
|
Rebased on master to get the windows build fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub considers skipped job as green when it comes to merging pull requests. We need to make the success job fails for real if any previous job is failed.