Skip to content

fix(sspi): make TLS backend configurable via features #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 2, 2024
Merged

fix(sspi): make TLS backend configurable via features #278

merged 6 commits into from
Aug 2, 2024

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented Aug 1, 2024

The aws-lc-rs backend is enabled by default.

@CBenoit
fix(sspi): make TLS backend configurable via features
efb7ee5 
The aws-lc-rs backend is enabled by default.
@CBenoit CBenoit requested a review from TheBestTvarynka August 1, 2024 16:20
@CBenoit CBenoit requested review from a team as code owners August 1, 2024 16:27
TheBestTvarynka
TheBestTvarynka approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@TheBestTvarynka TheBestTvarynka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I made two test runs on my environment:

  • First one with aws-lc-rs crypto backend.
  • Second one with ring crypto backend.

It connected successfully in both cases.

@CBenoit
Copy link
Member Author

CBenoit commented Aug 2, 2024

Thank you!! @TheBestTvarynka
I fixed CI for Android, should be good to go.

@CBenoit CBenoit enabled auto-merge (squash) August 2, 2024 05:24
@CBenoit CBenoit merged commit c2ecda7 into master Aug 2, 2024
42 checks passed
@CBenoit CBenoit deleted the configurable-tls-backend branch August 2, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awakecoding awakecoding awakecoding approved these changes

@TheBestTvarynka TheBestTvarynka TheBestTvarynka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CBenoit @awakecoding @TheBestTvarynka