Skip to content

System tests for whitelist validation #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2025

Conversation

olliesilvester
Copy link
Collaborator

@olliesilvester olliesilvester commented Jun 26, 2025

Fixes #96

After fixing existing system tests, I noticed a lot of the blank tests I'd added were already covered. This PR just adds ones extra test, as well as fixing the others to work with the whitelist

To test:

  • Outside of the dev container, get a local running image of the config server by running daq-config-server/deployment/build_and_push.sh -r -b
  • Inside the dev container, run pytest . with a terminal in daq-config-server
  • Confirm all tests pass

@olliesilvester olliesilvester marked this pull request as ready for review June 26, 2025 15:16
Copy link
Collaborator

@Relm-Arrowny Relm-Arrowny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it look very reasonable to me,

@olliesilvester olliesilvester merged commit 52efbd8 into main Jun 30, 2025
21 checks passed
@olliesilvester olliesilvester deleted the 96_system_tests_for_whitelist_validation branch June 30, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create system tests for whitelist validation
2 participants