Skip to content

Removed references to CPU and GPU comparisons #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adaudon
Copy link
Contributor

@adaudon adaudon commented May 29, 2025

Partially fixes mx-bluesky#449

Instructions to reviewer on how to test:

  1. Confirm tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@adaudon adaudon requested a review from a team as a code owner May 29, 2025 14:18
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (bd61397) to head (3746b48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   98.06%   98.00%   -0.06%     
==========================================
  Files         203      203              
  Lines        7788     7765      -23     
==========================================
- Hits         7637     7610      -27     
- Misses        151      155       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I think we can also remove a bit more:

  • get_dict_differences is no longer called
  • This means that deepdiff is no longer needed in dodal so we can remove it from pyproject.toml
  • However, we do use it in mx-bluesky, where we expect it to have come in from dodal so we will need to add it in to the pyproject.toml of mx-bluesky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants