Merge pull request #506 from DiamondLightSource/436_no_longer_try_to_…

…clean_vds 436 no longer clean unused links
DiamondLightSource · Jan 27, 2023 · 44bc20d · 44bc20d
2 parents 27aea19 + 38f27cc
commit 44bc20d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/src/artemis/external_interaction/nexus/write_nexus.py b/src/artemis/external_interaction/nexus/write_nexus.py
@@ -14,7 +14,7 @@
 import numpy as np
 from nexgen.nxs_write.NexusWriter import ScanReader, call_writers
 from nexgen.nxs_write.NXclassWriters import write_NXentry
-from nexgen.tools.VDS_tools import clean_unused_links, image_vds_writer
+from nexgen.tools.VDS_tools import image_vds_writer
 
 from artemis.devices.detector import DetectorParams
 from artemis.devices.fast_grid_scan import GridAxis, GridScanParams
@@ -284,16 +284,6 @@ def create_nexus_file(self):
                     start_index=self.start_index,
                 )
 
-                clean_unused_links(
-                    nxsfile,
-                    (
-                        self.full_num_of_images,
-                        self.detector["image_size"][0],
-                        self.detector["image_size"][1],
-                    ),
-                    start_index=self.start_index,
-                )
-
     def update_nexus_file_timestamp(self):
         """
         Write timestamp when finishing run.

diff --git a/src/artemis/external_interaction/unit_tests/test_write_nexus.py b/src/artemis/external_interaction/unit_tests/test_write_nexus.py
@@ -290,6 +290,7 @@ def test_nexus_file_validity_for_zocalo_with_three_linked_datasets(
     check_validity_through_zocalo(dummy_nexus_writers_with_more_images)
 
 
+@pytest.mark.skip("Needs fixing in Nexgen")
 def test_GIVEN_some_datafiles_outside_of_VDS_range_THEN_they_are_not_in_nexus_file(
     dummy_nexus_writers_with_more_images: tuple[NexusWriter, NexusWriter]
 ):