Skip to content

Updated pressure cell plans after AllValvesControl interface simplification #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
barnettwilliam wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Updated pressure cell plans after AllValvesControl interface simplification #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb23995
Updated pressure cell plans following AllValvesControl simplified int…
barnettwilliam Feb 17, 2025
e84a621
Missed in previous commit.
barnettwilliam Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/i22_bluesky/plans/test_pressure_cell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ def lower_pressure(
"""
# todo not sure what is the difference exactly
yield from bps.read(
pressure_cell.all_valves_control.set_valve(6, FastValveControlRequest.OPEN)
pressure_cell.all_valves_control.set({6:FastValveControlRequest.OPEN})
)
yield pressure_cell.all_valves_control.set_valve(6, FastValveControlRequest.OPEN)
yield pressure_cell.all_valves_control.set({6:FastValveControlRequest.OPEN})
# the pressure lowering itself
yield pressure_cell.pump.pump_motor_direction(PumpMotorDirectionState.REVERSE)
yield pressure_cell.pump.pump_position.set(target_pressure)
Expand All @@ -65,7 +65,7 @@ def raise_pressure(
for raise 5 must be open

"""
yield pressure_cell.all_valves_control.set_valve(5, FastValveControlRequest.OPEN)
yield pressure_cell.all_valves_control.set({5:FastValveControlRequest.OPEN})

# the pressure raising itself
yield pressure_cell.pump.pump_motor_direction(PumpMotorDirectionState.FORWARD)
Expand Down
Loading