Update Eiger API #111
Open
Update Eiger API #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GDYendell
commented
Aug 23, 2024
•
GDYendell
commented
- Depends on Fix eiger stream #104
GDYendell
force-pushed
the
eiger-api
branch
2 times, most recently
from
9c25907
to
4664a7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 94.32% 94.74% +0.42%
==========================================
Files 34 34
Lines 1620 1751 +131
==========================================
+ Hits 1528 1659 +131
Misses 92 92 ☔ View full report in Codecov by Sentry. |
abbiemery
reviewed
Aug 27, 2024
GDYendell
force-pushed
the
fix-eiger-stream
branch
from
9118017
to
00b424c
Compare
|
I have just pushed this branch and it hasn't updated the PR or triggered the CI... |
GDYendell
force-pushed
the
eiger-api
branch
3 times, most recently
from
c750000
to
4db4ceb
Compare
|
Fixed the CI 🔨 Eiger coverage is now 100% |
GDYendell
force-pushed
the
eiger-api
branch
4 times, most recently
from
016d5de
to
262479b
Compare
Except for allowed values of element, which seem to be completely different and I don't have the energies to input for each element. Note some of these changes apply to the old firmware.
Currently the sim does not implement ntrigger correctly and always only does one trigger. This updates the logic to produce a series with nimage images, repeating ntrigger times, as the real detector does.
Arguably this is a bug, but it is what the real detector does.
GDYendell
force-pushed
the
eiger-api
branch
from
262479b
to
76c6b76
Compare
4 tasks
|
Did you have any more comments on this @abbiemery ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.