-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1033 Migrating GEOADD and GEODIST command #1185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YuvrajGosain can follow sample doc template and update for these commands accordingly it'd be helpful.
@YuvrajGosain please resolve conflicts once. |
@YuvrajGosain hope you are doing well. Can you please update latest changes on this PR? |
Hi @AshwinKul28 , @lucifercr07 , Apologies for the late reply , was busy in some personal stuff and wasn't able to check the status for this, I'll rebase the PR and add docs for these commands by today. |
059de68
to
5ed865a
Compare
Hi @AshwinKul28 , @lucifercr07 , I have rebased this branch with the master and added the docs for both the commands as well. |
@YuvrajGosain Please address the remaining review comments |
Resolving Merge Conflicts
6f7ef44
to
1824a25
Compare
@JyotinderSingh Hi , I have addressed the comments and rebased the branch with master. Pls have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this massive migration effort @YuvrajGosain! The changes mostly look good, just had a few minor comments.
Hi @JyotinderSingh , just realized that I also pushed the changes onto the branch simultaneously and saw it being merged :) |
Issue: #1033