Added ZADD options implementation - XX|NX|CH|INCR| LT|GT according to Redis source code #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution, please add the respective integration tests into the resp, HTTP, and websocket directories. |
Co-authored-by: bhima2001 <[email protected]> Co-authored-by: psr <[email protected]> Co-authored-by: Jyotinder Singh <[email protected]> Co-authored-by: Arpit Bhayani <[email protected]>
* added startup splash and info table * Update main.go * more refactoring
* removed unwanted goroutine * made errors lowercase to match with the existing scenario of redis * added startup splash and info table * Update main.go * more refactoring * fixed printing of num shards in case of single threading --------- Co-authored-by: Ashwin Arvind Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the option parsing for the ZADD command by Redis. Additionally, I wrote unit and integration test cases to cover the functionality.
@apoorvyadav1111 Please review this and let me know if any modifications are needed. Thank you!
I added the evaluated command logic, which handles ZADD based on option flags and operates according to the Redis source code. I also created the zset_test file, which contains test cases for the command with various combinations of options.
PR for Issue #761
Closed PR related to the above #1138
Thanks!