#1100: Fix LPOP to support multiple arguments #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a few conflicts, please rebase on master. |
tren03
force-pushed
the
lpop-multiple-args-fix-1100
branch
from
12f7b48
to
53f07c8
Compare
|
Yep done |
There was a problem hiding this comment.
Thanks for these fixes @tren03! The changes look good overall, have left a few minor comments.
JyotinderSingh
requested changes
Nov 7, 2024
|
I have implemented the changes. Any other modifications? |
JyotinderSingh
approved these changes
Nov 8, 2024
|
There is a segfault in one of the tests, could you please take a look? |
|
Looks like the test failure is unrelated to this PR. Merging this for now. |
JyotinderSingh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #1100, where the LPOP command needed to support an additional argument to specify the number of elements to pop from the left side of the list.
Changes:
Modified the LPOP command to accept either 1 or 2 arguments:
LPOP key: Pops a single element from the list (default behavior).
LPOP key count: Pops up to count elements from the list.
Validation:
If count is 0, an empty response is returned.
If count is negative, an "out of range" error is returned.
If count exceeds the number of available elements, it pops as many elements as available without error.
Invalid count (non-integer values) returns an appropriate error.
Popping from a non-existent or empty list returns nil.
Behavior:
Returns a single element if one element is popped.
Returns a list of elements if multiple elements are popped.
Added the unit test and integration test, added integration tests for http too.
Currently working on adding the websockets tests