Refactored Eviction framework with Basic LRU based Batch Eviction #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumya-codes
commented
Nov 11, 2024
|
|
||
| for h.Len() > 0 { | ||
| item := h.pop() | ||
| store.Del(item.key, WithDelCmd(Evict)) |
There was a problem hiding this comment.
@JyotinderSingh wanted to discuss if we need some kind of special handling during eviction for QWATCH and WATCH implementations.
soumya-codes
force-pushed
the
soumya-codes/eviction
branch
3 times, most recently
from
2854dab
to
480eadb
Compare
soumya-codes
force-pushed
the
soumya-codes/eviction
branch
from
480eadb
to
4d77780
Compare
JyotinderSingh
approved these changes
Nov 13, 2024
soumya-codes
force-pushed
the
soumya-codes/eviction
branch
2 times, most recently
from
df3b33a
to
6ce1e7a
Compare
Signed-off-by: soumya-codes <[email protected]>
soumya-codes
force-pushed
the
soumya-codes/eviction
branch
from
6ce1e7a
to
0030a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the eviction framework and adds the basic implementation for Basic LRU based Batch Eviction.