Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#632: Feature: KeepAlive and Timeout Support #745

Closed
wants to merge 12 commits into from

Conversation

Dev79844
Copy link
Contributor

@Dev79844 Dev79844 commented Sep 27, 2024

Issue: #632

Summary:
Added timeouts and keep alive mechanism for workers.

Changes:
Added client, connection and command timeout in worker struct
Added functions related to keep alive and timeouts in workers.go

@Dev79844 Dev79844 marked this pull request as ready for review September 28, 2024 13:32
@JyotinderSingh
Copy link
Collaborator

  1. Please link the associated issue in the PR description.
  2. Add context around these changes in the PR description.
  3. Rebase and resolve conflicts

@JyotinderSingh JyotinderSingh self-requested a review October 1, 2024 01:52
@Dev79844 Dev79844 changed the title add: timeouts and keepalive struct in baseworker #632: Feature: KeepAlive and Timeout Support Oct 1, 2024
@Dev79844
Copy link
Contributor Author

Dev79844 commented Oct 1, 2024

Hey. @JyotinderSingh
I have resolved the conflicts and added description in the PR

@lucifercr07
Copy link
Contributor

@Dev79844 please resolve conflicts here

@Dev79844
Copy link
Contributor Author

Hey @lucifercr07 @JyotinderSingh
Created a new PR since I was getting too many merge conflicts when rebased the code.
PR #1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants