Skip to content

Homepage edits #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 8, 2024
Merged

Homepage edits #7

merged 35 commits into from
Aug 8, 2024

Conversation

Dindihub
Copy link
Owner

@Dindihub Dindihub commented Aug 7, 2024

This PR covers issue #4

@chalin please review. Thanks

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for tuf-homepage ready!

Name Link
🔨 Latest commit dea8c7e
🔍 Latest deploy log https://app.netlify.com/sites/tuf-homepage/deploys/66b550a4865e2b00082a9db3
😎 Deploy Preview https://deploy-preview-7--tuf-homepage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: sandra <[email protected]>
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes.

See inline comments for preliminary feedback.

Please ensure that you merge #6 first, and then rebase the PR to remove the changes introduced by #6 ...

Then (force) push back to this PR so that I can see the clean set of changes.

@chalin
Copy link
Collaborator

chalin commented Aug 8, 2024

HI. As it says in the comments of https://github.com/Dindihub/docsy-tuf.io/actions/runs/10299082608/job/28505627683?pr=7, you need to run npm run fix:format to fix the formatting, and then push the changes.

Signed-off-by: sandra <[email protected]>
@Dindihub
Copy link
Owner Author

Dindihub commented Aug 8, 2024

HI. As it says in the comments of https://github.com/Dindihub/docsy-tuf.io/actions/runs/10299082608/job/28505627683?pr=7, you need to run npm run fix:format to fix the formatting, and then push the changes.

@chalin The format checks are failing because of this code format. When I run npm run fix: format , it moves the CSS class to another line which distorts the styling of the CNCF logo. I don't know how to go about it. What would you advice?
Screenshot 2024-08-08 121941

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions, and a fix for your Prettier issues :).

@chalin
Copy link
Collaborator

chalin commented Aug 8, 2024

@chalin The format checks are failing because of this code format. When I run npm run fix: format , it moves the CSS class to another line which distorts the styling of the CNCF logo. I don't know how to go about it. What would you advice? !

See my last review suggestions. They obviate the need for the CSS class, and so will resolve you issue with the formatter.

Dindihub and others added 6 commits August 8, 2024 20:31
@Dindihub
Copy link
Owner Author

Dindihub commented Aug 8, 2024

Hi @chalin I'm done making the edits. Please review. Thanks

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin chalin merged commit 72aada7 into main Aug 8, 2024
6 checks passed
@chalin chalin deleted the homepage branch August 8, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants