Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: always-on-top setting #3347

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

DogeDark
Copy link
Member

This PR fixes the always-on-top setting (the environment variable wasn't being set) and also makes a few revisions to make CliSettings the single source of truth for the settings it contains.

@DogeDark DogeDark added enhancement New feature or request cli Related to the dioxus-cli program labels Dec 13, 2024
@jkelleyrtp jkelleyrtp added this to the 0.6.2 milestone Jan 9, 2025
packages/cli/src/dioxus_crate.rs Outdated Show resolved Hide resolved
@DogeDark DogeDark requested a review from a team as a code owner January 21, 2025 06:09
@DogeDark DogeDark requested a review from jkelleyrtp January 21, 2025 06:11
@jkelleyrtp jkelleyrtp merged commit 4342ca9 into DioxusLabs:main Jan 21, 2025
16 of 17 checks passed
@DogeDark DogeDark deleted the fix-always-on-top branch January 21, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the dioxus-cli program enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants