Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cli package name search #3561

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: cli package name search #3561

merged 1 commit into from
Jan 13, 2025

Conversation

Anakael
Copy link
Contributor

@Anakael Anakael commented Jan 13, 2025 •
edited
Loading

Resolves #3546

Now, if bin param not specified for dx it firstly fallback default-run target, secondly to single bin target thirdly to package name.

default-run case:
image
image

single bin case:
image
image

@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Jan 13, 2025
jkelleyrtp
jkelleyrtp approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't use default_run too often so we never really hit it. This looks good to me.

@jkelleyrtp jkelleyrtp merged commit 36522cf into DioxusLabs:main Jan 13, 2025
17 checks passed
@Anakael Anakael changed the title fix: cli pakage name search fix: cli package name search Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cli Related to the dioxus-cli program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dx serve failed to run project migrated from 0.5 to 0.6.1 after updating CLI
3 participants
@Anakael @jkelleyrtp @ealmloff