-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Don't use inline scripts and function constructor #4310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use inline scripts and function constructor #4310
Conversation
There is still something missing |
dioxus/packages/web/src/document.rs Line 171 in f610c6b
|
e1c5f51
to
d75bf9e
Compare
This allows a stricter Content-Security-Policy which is required for web extensions.
d75bf9e
to
7092b45
Compare
Should be ready now |
I don't think this will work with fullstack streaming like the |
That would not work for web extensions ( It seems that loading the module script asynchronously is possible and seems to pass the test. |
I don't understand the CI failures here. What do I need to do? |
CI failures are unrelated dependency issues I'm working on fixing them in #4312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! The async flag works for fullstack streaming when I tested it. Overall, I think this is a better approach, but there are a few spots that could be refactored a bit
ed3bd16
to
acce49a
Compare
Should be ready but I have not tested this yet and don't have more time today. |
Looked like it works for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Confirmed this has the right loading behavior for streaming in debug and release mode
This allows a stricter Content-Security-Policy which is required for web extensions.
Related #3866 #808 and possibly #1484