fix: Handle HTTP errors in FromResponseParts #5243
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5226
Fixed #5089
Problem
When decoding server function responses, if the return type goes through the
FromResponsePartspath (for exampleSetHeader<SetCookie>and similar types), the following implementation is used:dioxus/packages/fullstack/src/magic.rs
Lines 235 to 251 in d01a820
In the current implementation, this path ignores the HTTP status code (for example 4xx/5xx) and the response body containing error details. As a result, a non-2xx response can be incorrectly decoded as a success (for example
Ok(SetHeader { data: None }))when the expected header is missing. This masks real server errors and makes the behavior inconsistent compared to theDeserializeOwneddecoding path.