Fix panic in calculator when pressing ± after AC#5352
Open
Bortlesboat wants to merge 1 commit intoDioxusLabs:mainfrom
Open
Fix panic in calculator when pressing ± after AC#5352Bortlesboat wants to merge 1 commit intoDioxusLabs:mainfrom
Bortlesboat wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
calc_val() panics on empty string when AC is pressed before the plus-minus button. Return 0.0 early for empty input. Fixes DioxusLabs#4858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing AC clears the display to an empty string, then pressing ± calls
calc_val("")which panics at&val[0..1]because byte index 1 is out of bounds. Added an early return of 0.0 for empty input.Fixes #4858