Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dht variance contributions table #71

Closed
wants to merge 3 commits into from
Closed

dht variance contributions table #71

wants to merge 3 commits into from

Conversation

dill
Copy link
Contributor

@dill dill commented Dec 5, 2022

Adding a variance contributions output table

@dill dill marked this pull request as draft December 5, 2022 10:59
@dill
Copy link
Contributor Author

dill commented Dec 5, 2022

Resolves (at least partially) issues #52, #63 and #70.

@dill
Copy link
Contributor Author

dill commented Dec 5, 2022

Possible additional changes per chat with @lenthomas:

  • display both expected and observed group size and standard error on request
  • update documentation to let people know what's happening in this table
  • remove "clusters" results, only report individuals by default? (Just changing the print method.)
  • by default print variance contributions

So by default users will see table for individuals estimates adn the variance contributions table.

addresses most of what is in this comment
906a1ff 
#71 (comment)
but probably doesn't have enough documentation
@dill
Copy link
Contributor Author

dill commented Dec 5, 2022

The above comment is now addressed minus the general comments needed in the documentation. See ?print.dht for new options.

This was referenced Dec 5, 2022
Open
Closed
@LHMarshall
Copy link
Member

See issue #76

@LHMarshall
Copy link
Member

I have now moved these changes to dht-var-tables-LM I will merge them in to master from there

@LHMarshall LHMarshall closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dill @LHMarshall