Patch #8
Open
Patch #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djelibeybi
requested changes
Mar 2, 2025
There was a problem hiding this comment.
Please use the same name for both parameter and variable, to make it less confusuing/ambiguous for users.
Also, could you please make the dnssleep parameter optional? Using the DNS challenge alias as an example, it should look something like this:
if bashio::config.has_value 'dnssleep'; then
DNS_SLEEP=$(bashio::config 'dnssleep')
DNS_SLEEP_PARAM=$(printf " --dnssleep %s" "$DNS_SLEEP")
fiThen you'd add ${DNS_SLEEP_PARAM} to the acme.sh command in the script.
Otherwise, thanks for contributing!
| @@ -35,6 +36,7 @@ schema: | |||
| - str | |||
| dnsprovider: str | |||
| dnschallengealias: str? | |||
| dnswaittime: int | |||
There was a problem hiding this comment.
Suggested change
| dnswaittime: int | |
| dnssleep: int |
| @@ -22,6 +22,7 @@ options: | |||
| domains: null | |||
| dnsprovider: null | |||
| dnschallengealias: "" | |||
| dnswaittime: 30 | |||
There was a problem hiding this comment.
Suggested change
| dnswaittime: 30 | |
| dnssleep: 30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a DNS-Sleep option