Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disable Comment Loading to Data Saver Settings #1286

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CThompson01
Copy link

@CThompson01 CThompson01 commented Dec 17, 2022

Feature Description

Added the ability to disable comment fetching from the data saver settings when viewing the post details screen. This allows for posts that are too long for the preview to be viewed fully without loading comments.

The setting added is shown below.
image

Reason for Adding the Feature

This is a feature that I have seen other apps implement and can be helpful for users who need to save data or just don't care about viewing comments. Users will mostly get use out of this feature when viewing posts that are lengthy and too long to be shown fully without viewing the post details screen.

CThompson01 and others added 2 commits December 16, 2022 23:14
Added the ability to disable comment fetching for the data saver settings.
@Docile-Alligator
Copy link
Owner

Thank you. But changes in PostRecyclerViewAdapter is not needed since comment loading happens in ViewPostDetailFragment. For the same reason, ChangeDisableCommentLoadingEvent should be removed too since we do not have to observe the preference change.

Remove disable comment event since the preference can only be changed when in the data saver screen. Fixed an issue where the Disable Comment preference on the Data Saver screen would only update when the screen was exited and re-entered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants