Add Indices to Foreign Key Columns in SubscribedSubredditData, SubscribedUserData and MultiReddit#1687
Merged
Docile-Alligator merged 6 commits intoDocile-Alligator:masterfrom Mar 16, 2025
Conversation
|
@Docile-Alligator is there any reason we don't want to merge this? |
Owner
|
@iDaoU oh right. Sorry I forgot. Will merge it soon. |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Problem:
In the current implementation, the
usernamecolumn in theSubscribedSubredditData,SubscribedUserData, andMultiReddittables references a foreign key but is not indexed. This may trigger full table scans whenever the parent table is modified, leading to performance issues.Details: https://github.com/Docile-Alligator/Infinity-For-Reddit/actions/runs/10067294236/job/27830465944#step:4:109
Solution:
To resolve this, indices have been added to the
usernamecolumns in the database tables. Additionally, the database schema version has been incremented and migration strategies have been provided to handle the creation of these indices.Testing:
Checklist:
@Indexannotation tousernamecolumns.Please review and merge the changes.