feat: Introduce dual testing with redis and bitmapist-server#84
Merged
jacobo-doist merged 8 commits intomainfrom Oct 17, 2025
Merged
feat: Introduce dual testing with redis and bitmapist-server#84jacobo-doist merged 8 commits intomainfrom
jacobo-doist merged 8 commits intomainfrom
Conversation
Since the tests now support a previously running instance of the backend, this introduces a protection in case the tests get accidentally connected to production data.
We only need the dev group and: https://docs.astral.sh/uv/concepts/projects/sync/#syncing-development-dependencies > The dev group is special-cased and synced by default.
|
Adding @lukemerrett as a reviewer as he took an interest in going deep into |
modasserbillah
approved these changes
Oct 17, 2025
modasserbillah
left a comment
modasserbillah
left a comment
There was a problem hiding this comment.
It is a test only change and CI already ran the tests on both redis and bitmapist. So, it looks safe and functioning to me. Thanks @jacobo-doist 🎉
|
Thank you @modasserbillah 🙏 |
Contributor
|
Awesome, thank you for the turnaround on this @jacobo-doist ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests now run against both Redis and bitmapist-server backends.
Changes
test/conftest.pyto run tests with both backendsdocker-compose.ymlwithredis:7-alpineandbitmapist-server:v1.9.8Testing