Skip to content

feat(base-field): Add CSS props for customizing label spacing #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

feat(base-field): Add CSS props for customizing label spacing #925

merged 1 commit into from
May 27, 2025

Conversation

pawelgrimm
Copy link
Contributor

@pawelgrimm pawelgrimm commented May 27, 2025 •
edited
Loading

Short description

We are adding two new Custom CSS Properties so that consumers can control:

  • Field label line heights: --reactist-field-label-line-height
  • Field label bottom padding (i.e. space between label and field): --reactist-field-label-padding-bottom

Show PR for tiny change.

PR Checklist

  • Added tests for bugs / new features
    • Changes only affect component display and will be caught by visual regression tests
  • Updated docs (storybooks, readme)
    • Changes are for an internal component, which doesn't have docs
  • Reviewed and approved Chromatic visual regression tests in CI

@pawelgrimm pawelgrimm marked this pull request as ready for review May 27, 2025 19:14
@pawelgrimm pawelgrimm requested review from a team and engfragui and removed request for a team May 27, 2025 19:14
@pawelgrimm pawelgrimm self-assigned this May 27, 2025
@pawelgrimm pawelgrimm added the 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. label May 27, 2025
@pawelgrimm pawelgrimm merged commit 12e99fd into main May 27, 2025
8 checks passed
@pawelgrimm pawelgrimm deleted the pawel/core/customizable-field-label-styles branch May 27, 2025 19:15
@github-actions github-actions bot mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engfragui engfragui Awaiting requested review from engfragui engfragui was automatically assigned from Doist/frontend-product

Assignees

@pawelgrimm pawelgrimm

Labels
👀 Show PR Used for PRs that need a review, but can be merged when CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pawelgrimm