-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build form optimization #1572
build form optimization #1572
Conversation
@Siumauricio |
The project currently uses |
@vishalkadam47 I will install Biome, and remove the prettier dependency but my point on formatting style is still valid |
Add in this PR #1578 an autofix to always format the code correctly. |
I still believe that the current formatting using tabs makes code review, at least here on github on a normal screen nearly imposible. |
Added prettier to the project dev dependencies, tried to match current style in the .prettierrc config
added prettier tailwind plugin too
Refactored the ShowBuildChooseForm component to:
Extract duplicated form reset logic into a helper function (resetData)
Use a mapping for rendering the radio group items from the BuildType enum
buildTypeDisplayMap based on BuildType for Labels
Tested locally and confirmed that the form state updates correctly.