Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build form optimization #1572

Merged

Conversation

thebadking
Copy link
Contributor

Added prettier to the project dev dependencies, tried to match current style in the .prettierrc config
added prettier tailwind plugin too

Refactored the ShowBuildChooseForm component to:

Extract duplicated form reset logic into a helper function (resetData)
Use a mapping for rendering the radio group items from the BuildType enum
buildTypeDisplayMap based on BuildType for Labels

Tested locally and confirmed that the form state updates correctly.

@thebadking thebadking requested a review from Siumauricio as a code owner March 28, 2025 17:36
@thebadking
Copy link
Contributor Author

@Siumauricio
personally I dont like "useTabs": true,
I did it to match current style, but this makes reviewing code on github extremely hard

@vishalkadam47
Copy link
Contributor

The project currently uses Biome, adding Prettier might be redundant.

@thebadking
Copy link
Contributor Author

@vishalkadam47 I will install Biome, and remove the prettier dependency but my point on formatting style is still valid

@thebadking thebadking changed the title prettier and build form optimization build form optimization Mar 28, 2025
@Siumauricio
Copy link
Contributor

Add in this PR #1578 an autofix to always format the code correctly.

@thebadking
Copy link
Contributor Author

I still believe that the current formatting using tabs makes code review, at least here on github on a normal screen nearly imposible.

@thebadking thebadking requested a review from Siumauricio March 30, 2025 08:09
@Siumauricio Siumauricio merged commit ffc85b0 into Dokploy:canary Mar 30, 2025
4 checks passed
@thebadking thebadking deleted the refactor-show-build-form-and-prettier branch March 31, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants