FIX concatenation of labels in extrafields #36888
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IF: - The extrafield is of type "Select from list" - AND it would use a join as table - AND the label would be a concatenation of fields from both tables THEN, the EF value could not be displayed (showOutputField os showInputField). example of syntax that would trigger this error : `commande c INNER JOIN llx_societe s ON s.rowid = c.fk_soc:s.nom|c.ref:c.rowid::` This commit fixes this.
eldy
reviewed
Jan 16, 2026
| if (is_array($fields_label) && count($fields_label) > 1) { | ||
| $notrans = true; | ||
| foreach ($fields_label as $field_toshow) { | ||
| $field_toshow = preg_replace('/^.*\./', '', $field_toshow); |
Member
There was a problem hiding this comment.
Imagine the field to concat is
s.rowid|c.note
With pfix, you will get
rowid|label
But rowid field like note may be both in table s and c. So final request may generate an error with error "ambiguous field". Why keeping the alias is wrong ?
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX concatenation of labels in extrafields
Follows discussion in PR #36835
IF:
example of syntax that would trigger this error :
output :
This commit fixes this.